-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function to create a sticker #12
Comments
that's awesome. Thanks @lgatto |
Very nice 👍 🥇 |
TODO
TODO list has been moved to |
I vote for new package, maybe |
p <- ggplot(aes(x = mpg, y = wt), data = mtcars) + geom_point()
p = p + theme_void() + theme_transparent()
make_sticker(p, "Bioconductor") 142d1f5 change the dimension according to https://twitter.com/robbie_bonelli/status/795211775679418372. |
Ok for a package; I would rather name it If we push actual sticker creation functions in there, then this repo becomes obsolete. The advantage of an external package is that it easier for me to control what version I use for my sticker; otherwise, every change in the function (like 142d1f5, for example), possibly breaks stickers. With respect to the package, having it on |
I would only make a package of the functionality to create the stickers and would not include the actual stickers or sticker functions into that package. 1) some stickers (mine ;) ) were made manually and 2) I would simply keep functionality (the function) and results (the stickers) separate. |
I realized that the hexagon is not filling the full square. On the left side there is a small gap. Could this be fixed? |
I have created a |
@lgatto Is the function in the package different from the one we had here? I'm asking because the same code that generated this sticker https://github.com/jotsetung/BioC-stickers/blob/master/mzR/mzR.png now creates: |
There have been a couple of PRs recently, but I think that the text size is also influenced by other parameters (at least that's what I observed yesterday, when preparing the |
This is because the units are in two different spaces (data and pixel). |
Yup, I just reduced the size of the text - works now. |
I have some ideas to improve it and create a package separately for not breaking your existing codes. |
Based on @GuangchuangYu's script, I created the
make_sticker
function to make it easier to re-use and adapt. It's rough around the edges but a decent start. Suggestions and patches welcome.The text was updated successfully, but these errors were encountered: