Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Render / Turntable #43

Open
wants to merge 112 commits into
base: main
Choose a base branch
from
Open

Enhancement: Render / Turntable #43

wants to merge 112 commits into from

Conversation

BigRoy
Copy link
Owner

@BigRoy BigRoy commented Dec 22, 2023

Feature

Implements features playblasting/rendering using the USD view API.

Intends to replace open PR #30 since it contains it completely with some more cosmetics cleaning

Sasbom and others added 30 commits November 27, 2023 19:58
@Sasbom
first commit, adding playblast module
cd7fc55
@Sasbom
added utility and expanded on renderplayblast args and processing
32b90dc
@Sasbom
parsing complexity argument better, fixed walrus bugs
663f958
@Sasbom
slight refactor
eb84c53
@Sasbom
ConverFramePlaceholderblabla does internal None checking, so removed …
d04aad3 
…extra checks.
@Sasbom
Merge branch 'BigRoy:main' into enhancement/usdview_render_turntable
bbac50c
@Sasbom
Removed hardcoded complexity presets, added sanity checking for rende…
8b9f7e6 
…r engine arg
@Sasbom
Complete framerecorder initialization setup
b6c429c
@Sasbom
Merge branch 'BigRoy:main' into enhancement/usdview_render_turntable
623f105
@Sasbom
resources_rc added
13f62c4
@Sasbom
added menu, functionality for snapshot. Doesn't work as intended with…
6d1e89e 
…in hython 19.5.
@Sasbom
snapshot fix! Works now. Still needs major cleanup.
94716ab
@Sasbom
Merge branch 'BigRoy:main' into enhancement/usdview_render_turntable
14e5e00
@Sasbom
changed logic in case no camera is selected to match usdrecord
028fdd4
@Sasbom
Merge branch 'enhancement/usdview_render_turntable' of https://github…
583f35b 
….com/Sasbom/usd-qtpy into enhancement/usdview_render_turntable
@Sasbom
house cleaning, suggested bugfixes
d7f4b9d
@Sasbom
slowly but surely adding methods to deal with cameras
09a041b
@Sasbom
added distance calculation function while downstairs neighbours are d…
d69188d 
…rilling in walls. Might need to check this later.
@Sasbom
finished clipping planes function.
962ab0c
@Sasbom
finished calculate camera position function.
b86915c
@Sasbom
cross platform catch for non-OGL native systems (macosx)
6b293db
@Sasbom
Completed routine to add a framing camera!
1b934c1 
You can even set the aspect ratio. Amazing.
There is still some stuff to be done to make a turntable work, but this
is an important step on the road there.
@Sasbom
Merge branch 'BigRoy:main' into enhancement/usdview_render_turntable
6cc9386
@Sasbom
added fit parameter to add some padding
e0314a1
@Sasbom
micro commit to change a variable name in a function to something mor…
f93c85b 
…e sensible.
@Sasbom
Created render_util.turntable,
4bbdb2d 
this exposes utility functions for generating things that turn tables
and table turns, not just in cameras, but any prim that is Xformable.

Created render_util.turntable,
this exposes utility functions for generating things that turn tables
and table turns, not just in cameras, but any prim that is Xformable.
@Sasbom
bugfixes + exposed turntable render as temp functionality.
271917b
@Sasbom
bugfix: adjusted transforms when framing camera as turntable camera
60801ee
@Sasbom
added some utility to deal with the frame argument
b00d12f
@Sasbom
made tuples_to_frames_string.tuple_gen way more sane
cdf43c0
Sasbom and others added 21 commits December 12, 2023 02:51
@Sasbom
implemented turntable from file
2bf24b8
@Sasbom
cleaned up render menu in editor
ec8d45a
@Sasbom
minor cleanup
b543b86
@Sasbom
small fixes
f68ae5f
@Sasbom
First pass of cleanup.
2feabcd 
TODO: context managers for temporary cameras/scenes
@Sasbom
added context managers for managing open scenes and deleting files
4d0e808
@Sasbom
ExitStack shenanigans
5e85507
@Sasbom
ExitStack shenanigans part 2: the big bugfix
c104d5d
@Sasbom
fixed potential -1 index on camera box in playblast dialog
5fbaccb
@Sasbom
removed unneeded import to weakref
daf480f
@Sasbom
exposed select functions in __all__ and added missing stage context…
30463db 
… manager in playblast.get_file_cameras
@Sasbom
fixed spacing from top
184cc32
@Sasbom
removed unnessecary import
7f0720c
@Sasbom
modified size, disallowed resizing of playblast/turntable dialogs
c51e2af
@Sasbom
bugfix, making sure that right parameters get passed around and that …
57828f6 
…data is collected before files are deleted.
@BigRoy
Refactor imports
f8ffa7a
@BigRoy
Cosmetics
98e34ea
@BigRoy
Cleanup code; cosmetics
2b5bda6
@BigRoy
Cosmetics - move imports to top
1982636
@BigRoy
Add todo
b46b563
@BigRoy
Some code simplification - avoid the need for temporary files as much…
52efa6f 
… as possible
@BigRoy BigRoy added the enhancement New feature or request label Dec 22, 2023
@BigRoy BigRoy self-assigned this Dec 22, 2023
@BigRoy BigRoy mentioned this pull request Dec 22, 2023
Closed
Sasbom
Sasbom approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@Sasbom Sasbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for checking everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sasbom Sasbom Sasbom approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@BigRoy BigRoy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BigRoy @Sasbom