Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LimitsJoinPermCheckEvent with update #111

Closed
Guillaume-Lebegue opened this issue Nov 13, 2020 · 2 comments · Fixed by #112
Closed

LimitsJoinPermCheckEvent with update #111

Guillaume-Lebegue opened this issue Nov 13, 2020 · 2 comments · Fixed by #112
Assignees
@tastybento
Labels
under investigation this is being looked into

Comments

@Guillaume-Lebegue
Copy link

Is your feature request related to a problem? Please describe.
Using the Upgrades addon with Limits means that it's not possible to use permission.
Even with permission about limits not in upgrades

Describe the solution you'd like
Upgrade the LimitsJoinPermCheckEvent to be fired for each permission, with block type in it.
To select which permission to stop.

Describe alternatives you've considered
Redoing the permission part in upgrades.

Additional context
#101
BentoBoxWorld/Upgrades#29
@tastybento tastybento self-assigned this Nov 14, 2020
@tastybento tastybento added the under investigation this is being looked into label Nov 14, 2020
tastybento added a commit that referenced this issue Nov 14, 2020
@tastybento
Added new event that fires for each perm
c0c9e16 
#111
@tastybento tastybento mentioned this issue Nov 14, 2020
Merged
@tastybento tastybento linked a pull request Nov 14, 2020 that will close this issue
Added new event that fires for each perm #112
Merged
@tastybento
Copy link
Member

Please check #112 and let me know if this will meet your needs.

@Guillaume-Lebegue
Copy link
Author

Yes, I think that should be perfect, thanks

@Guillaume-Lebegue Guillaume-Lebegue mentioned this issue Nov 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
under investigation this is being looked into
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added new event that fires for each perm BentoBoxWorld/Limits
2 participants
@tastybento @Guillaume-Lebegue