Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Timestop is smaller #11973

Open
RDS88-beeman opened this issue Dec 3, 2024 · 4 comments
Open

[Bug]: Timestop is smaller #11973

RDS88-beeman opened this issue Dec 3, 2024 · 4 comments

Comments

@RDS88-beeman
Copy link
Contributor

BYOND Version

No response

Round Date

2024/12/01

Round ID

50846

Test merges

#9124: 'Enable serverside 515.1614' by Crossedfall at commit 1b8f225789
#10897: '[PORT] Follows up TG's atom_hud system' by EvilDragonfiend at commit 51f8edef4f

Describe the bug

As of recent PRs, the timestop effect used in wizard spells and xenobiology is 3x3, while both the graphic and prior effect was 5x5.

What did you expect?

I expected the timestop effect to be 5x5

Reproducible steps

  1. Create a timestop effect
  2. Observe the smaller range of the stun and visual effect
@PowerfulBacon
Copy link
Member

This is likely an accidental port from TG since I heard someone made an ided PR there to make it smaller. Not sure what is likely to have caused it

@PowerfulBacon
Copy link
Member

It's possible that this effects all fields, including timestop, proximity and peacekeeper fields

@RDS88-beeman
Copy link
Contributor Author

it's probably the proximity PR, like a rounding error or some shit

@PowerfulBacon
Copy link
Member

In Byond, range works as
0: 1x1
1: 3x3
2: 5x5

It may have been changed with this to:
0: Invalid
1: 1x1
2: 3x3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants