Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SRI estimation methods #258

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Nov 7, 2024

Issues addressed by this PR

Closes #257

Added methods to estimate SRI from a colour, or estimate thermal and solar emittance from an SRI (useful for creating building materials from target SRIs). Also made dataset references a bit easier to manage by defining these at module level.

Test files

See the included pytest files in this PR. The following may be run as an alternative:

from ladybugtools_toolkit.honeybee_extension.sri import estimate_sri_from_color, estimate_sri_properties

print(estimate_sri_from_color(color_hex="#a1b2c3", thermal_emittance=0.76))
print(estimate_sri_properties(target_sri=75.5, target_emittance=0.9))

Changelog

Additional comments

@tg359 tg359 added good first issue Good for newcomers size:S Measured in minutes type:feature New capability or enhancement priority:low Resources should be targeted to other issues first labels Nov 7, 2024
@tg359 tg359 self-assigned this Nov 7, 2024
@tg359 tg359 requested a review from msandmer November 8, 2024 14:30
Co-authored-by: Thomas Edward Kingstone <[email protected]>
@Tom-Kingstone
Copy link
Contributor

@BHoMBot check installer

Copy link

bhombot-ci bot commented Nov 11, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority:low Resources should be targeted to other issues first size:S Measured in minutes type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SRI methods
2 participants