Skip to content
This repository has been archived by the owner on Feb 13, 2021. It is now read-only.

Added ssh_private_ip config to enable use of VM private IP addresses #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ancillas
Copy link

When using an Azure VNet, public endpoints cannot be used to reach virtual machines.

This commit adds an ssh_private_ip config option which accepts a boolean value. When true, the private IP address of Azure VMs will be used when executing remote provisioning commands, instead of the public endpoint IP.

@msftclas
Copy link

Hi @Ancillas, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@Ancillas, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@@ -44,6 +44,7 @@ type Config struct {
tmpServiceName string
tmpContainerName string
userImageName string
SSHPrivateIp bool `mapstructure:"ssh_private_ip"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ssh_private_ip -> use_private_ip, also, let's do SSHPrivateIp -> UsePrivateIP to keep it consistent. (This should also made to work similarly for Windows VM's, once I get those over to using WinRM instead of CustomScript.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased my branch before I pushed, but I recall originally using use_private_ip. For some reason, I had a problem in that my config was never picked up, and was always empty. That's why I ended up changing to SSHPrivateIp.

It's highly likely I was doing something wrong. I'll try changing the value around and re-testing at my next opportunity.

@paulmey
Copy link
Member

paulmey commented Nov 17, 2015

The above comment should fix the build. Also please run go fmt to get rid of the spaces/tabs mix.
Thanks for contributing!

@Ancillas
Copy link
Author

Thanks for the feedback. I'll get the files formatted correctly as soon as I can.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants