-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added inline function analyzer #11
Conversation
d690dd5
to
076d6a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool tool!
Added my (cosmetic) review as a fixup commit:
- Added dataclasses
- Unprivated the
__functions
otherwise they wouldn't show in the docs. - Made all paths render as relative to CWD.
As a functional improvement I would recommend to add an integer (or float?) argument that describes the storage overhead of converting an inlined function into a non-inlined function. It would need at least a 16-bit branch instruction and probably also require moving around some registers. Perhaps best we just measure it for the largest candidate and then use that as an average number. I would assume that this gives a more realistic and smaller list of candidates (and filters out very small inlined functions).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is epic!
Example output:
|
Added an inline function analyzer to identify potential FLASH savings.