Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Prefer pipenv on project when possible #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

just-paja
Copy link

Hi,

thank you for this project. I noticed that it is very hard to configure the plugin when using pipenv. This could serve as an inspiration on how it could work.

There are still few glitches, but before I fix that, please let me know what you think.

The code reads projects configuration only once.

@just-paja
Copy link
Author

Umm.. Is this project still alive, @Arcanemagus?

@Arcanemagus
Copy link
Member

If I'm understanding what this is doing (I'm not well versed on pipenv personally) it seems like this would work for finding the path of a local pylint within a defined venv... however none of this seems to be enhancing the rest of the execution to use the other parts of the virtual environment.

Is that not necessary?


Unfortunately I don't use this project myself very often, and it seems nobody in @AtomLinter/linter-pylint is active here any longer 😒, sorry about the delay!

@illright
Copy link

@Arcanemagus it does affect the other parts. This code extracts the PYTHONPATH of the venv and adds it to the PYTHONPATH for further execution.

As someone who's using Pipenv in the project, I can confirm that this would be a valuable addition. Didn't test the PR yet, but maybe @just-paja is willing to finalize the changes.

@just-paja
Copy link
Author

Good evening @illright, it's Christmas time again :-D Sorry for the delay, I got occupied by other aspects of my life.

I do not really understand what changes need to be done except for resolving conflicts. If anyone helps me understand, I'll be happy to do the coding work ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants