feat: i18n for duplicated field names #6769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
| lint rule | new reports | level | link |
|---|---|---|---|
| Missing translation | 27 | warning | contribute (via Fink 🐦) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6769 +/- ##
==========================================
- Coverage 74.41% 65.09% -9.32%
==========================================
Files 245 273 +28
Lines 6566 10572 +4006
Branches 1057 1413 +356
==========================================
+ Hits 4886 6882 +1996
- Misses 1628 3517 +1889
- Partials 52 173 +121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -253,7 +253,8 @@ | |||
| "moreButtonToolTip": "Remove, rename, and more...", | |||
| "addPageTooltip": "Quickly add a page inside", | |||
| "defaultNewPageName": "Untitled", | |||
| "renameDialog": "Rename" | |||
| "renameDialog": "Rename", | |||
| "copy": "Copy" | |||
There was a problem hiding this comment.
Please give a more descriptive name to this translation token. Simply "copy" is misleading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4153
Feature Preview
We can pass the copy from suffix param, this will not require to add i18n string for copy in from the rust side. I have added a new key, as per the convention used. Should I use an existing key? as there will be no translations for this. @richardshiue
PR Checklist