ProxyShape::makeUsdTransformChain does not always setup resulting path. #19
Labels
Comments
murphyeoin
added
pending investigation
fix in progress
and removed
pending investigation
labels
seando-adsk
added a commit
to autodesk-forks/AL_USDMaya
that referenced
this issue
Nov 19, 2018
…on code (AnimalLogic#19) * MayaReference: shuffle code so it only tries to edit ns on loaded refs * fix import of AL.usd.maya.schemas * fix TranslatorContext::updatePrimTypes crash When updatePrimTypes was removing prims from the m_primMapping (should it even do that?), it wasn't using std::vector::erase correctly. * Save selection in pre-save and restore it in post_save * implement PR fixes * Fix for when tearing down a shape that it's sibling shapes are left alone * TranslatePrim now correctly works with mergedTransform flag * Move renderer selection to LayerManager * Introduce RendererManage command * Introduce code style changes * Make m_rendererPlugin a string attribute * Add documentation concerning renderer selection * Revert NodeHelper changes * Introduce to LayerManager rendererPlugin internal attribute and rendererPluginName storable attribute * Default to EarliestTime timecode * Added "forceDefaultRead" option for import and translate This is mainly to handle usd meshes which have generated with one time sample attribute values instead of using the default value. * Default to EarliestTime timecode * [AL_USDMayaUtils] Updated nurbs utils API * Ensure that time is always connected to imported proxy nodes - also don't rename transform nodes we have no right in renaming * Updated tests cmake configuration * [AL_USDMaya] Updated forceDefaultRead import parameter's doc * BugFix where you could only push changes to a Mesh once through the TranslateMesh Prim * [schemas] Fixed Windows exports * glext.h is not in the devkit anymore, switching files * Fixes for the Windows build : - Adding boost chrono lib only for Windows builds - Adding Python libraries dependency to fix link error on compile - Changing the cmake lookup file for plugins as glext.h will not be in a future devkit. * extract useful functions into AL_USDMayaUtils * remove unnecessary using * fix windows build * geometry diffing * fixed up some windows build errors & warnings fixed some more compiler warnings & errors for clang & VC more compiler warning fixes fixed maya2018 deprecation warning more build warning fixes Win32/clang fixed issue with prims not removing the parent transforms signed/unsigned mistmatch * unregister managerenderer * version up for utils package update * make LayerDatabase automatically hide non-dirty layers * remove old edit target from layerManager if it wasn't dirty * LayerDatabase now no longer has an easily queryable size, so add bool testing * Renamed functions * Fixed unittests regarding the LayerManager, it's lifetime and dirty tracked layers * LayerManager Command * Minor for AL_USDMayaUtils because of helper function refactor * Updated to 0.27.13 * Update README.md * Update README.md * Construct excluded prims list on attribute change * Consider excludedTranslatedGeometry changes * Move renderer related code to LayerManagerRenderer.cpp * Introduce RendererManager node * Introduce suggestions * Fixed InternalProxyShapeSelect to be used on selection change event * Removed debug saving of a Maya file in a test * removed the code that deletes files from /tmp, it's not needed * ensure the time value from the options is passed through to the export options. * removed the /tmp paths so the tests can run on Win32 * Added documentation for the maya mesh data * removed docs on leftHanded geometry, and fixed some grammar * fixed up doxygen warnings/errors. Removed a few incorrectly exported functions (they are inline). Removed duplicate setFloatArray/setDoubleArray * removed the leftHanded mesh handling code - the same result can be achieved with the opposite attribute * Skipped schemas tests if needed * [schemas] API schema as a non-applied schema * [schemas] Generated schema source code * Updated build doc * [translators] Fixed tests environment * Updated CHANGELOG * Boost date time temporarily added to Windows build * Updated patch version * Updated doc for LayerManager * make getRenderAttris update showRender * fixes to allow modification of rpath via command line ie, with this change, you can pass this to cmake: -D CMAKE_INSTALL_RPATH=/path/to/usd/lib/dir ...to make it so that you don't need to modify $LD_LIBRARY_PATH in order for the plugin to load / link against USD. If you do this, I also recommend passing these to cmake: -D CMAKE_EXE_LINKER_FLAGS=-Wl,--enable-new-dtags -D CMAKE_SHARED_LINKER_FLAGS=-Wl,--enable-new-dtags ...as this will make the resultant binary use RUNPATH, not RPATH, which is overridable by LD_LIBRARY_PATH. * add libAL_USDMayaTranslators's dir to it's RPATH, so it can find libAL_USDMayaSchemas * update the viewport for progressive renderers (like embree) * ProxyShapeUI: add trailing newline to TF_DEBUG statements * Updated cmake files (removed unused) * fixed issue with inverted normals * 0.28.2 update * added a command to create a prim on a usdstage of a specific type & kind * set ProxyDrawOverride's isAlwaysDirty to false This makes it so that prepareForDraw is only called if the shape actually needs to be updated, which should mean faster performance for situations where things don't change - tumbling the viewport being an important example required a fix for updating viewport when a transform moves * small performance tweak: prepareForDraw allows you to re-use old MUserData if the returned MUserData* is different than the one passed in, the old one is deleted; if the same, then it keeps it. Saves us some extra allocations... * don't trigger redraw when pushToPrim enabled on xform creation * moved shape naming code to prior the fileIO kicking in * make outStageData connectable * pass correct path to the selection * removed unused include * fixed a number of build wanrings on the OSS linux build * fixed version.h, and updated changelog.md * fix for regression wrt to transform values not being correctly reported into maya * added additional selection events for USDGlimpse to listen to * prevent changes in transform values being written to usd if the value has not changed * only time attribute to transforms that are actually transforms * also disconnect stage to non-valid TM's * reorganize ProxyDrawOverride::prepareForDraw to do all early exit checks first * register a PrimWriter translator for the proxyShape in pixars exporter * make sure loadStage is called when a proxyShape is duplicated, so that the new shape is ready for use. match braces style * allowed certain event types (those with Text Name ID) to have callbacks registered against them when the event type has yet to be registered * remove pointless exports from maya event handler, and fix up message type names * Update build.md * Update faq.md * Warnings as errors (Windows build) * python docs * ProxyShape docs * fixed up build warnings in opensource build * address robs comments * Updated to 0.28.4 * fix some remaining warnings - fix unused nullEventId warning - make Profiler::m_stackPos unsigned, to avoid warning (and because it should never be negative) - fix signed/unsigned comparison in assert (safe because in branch where checked >= 0) - TransfomationMatrix::insertRotateOp - avoid possibly using uninitialized op - Diffcore: remove unused variable in __AVX2__ branch * translatorProxyShape: set created reference offset based on proxyShape time offset + scale * this allows a layout artist to export references with various offsets * add a test for the translatorProxyShape and fix an issue where the prim type was getting cleared by CopySpec. * add missing include ...and undo move of other include * avoid an error if session layer has no specs defined * Add ALFrameRange openSource schema * Add ALFrameRange openSource translator * Add ALFrameRange translator tests * Add ALFrameRange tutorial * Fix the issue that translator decref parent transform chain too agressively * Add test for the fix for over-decref transform chain issue * Manually bump up patch version in Version.h * Update change log * Support layer identifiers for paths that are not on disk until they are resolved. Remove TfIsFile check and fix handling of relative path if the joined path doesnt exist. * Set session layer as the initial edit target for proxyShapes * Move storage of prim to dagPath out of session layer and onto a proxyShape property. * address review notes to use convert() * add missing triggers for Pre/PostStageLoaded events * add new Pre/PostDestroyProxyShape events * plugin translators refactoring first round * plugin translators refactoring first round * fix mesh tests * fix mesh tests * fix windows build * fix windows build * remove deprecated left handed option * fix up build warning due to unused var * updated the documentation * updated new frame range translator to use the new API * Fixed tests runtime environment for plugin translators * removed pointless export macros from inline methods * Disabled translatorProxyShape for now until we can depend on pxr usdMaya * Updated to version 0.29.0 * Disabled translatorProxyShape test as feature is currently off * Add error logging if the creation of transform chain actually failed * Only create renderEngine if it is in interactive mode * Use MGlobal::displayError instead of std::cerr * Add more comment * support for linear / quadratic light decay in VP2.0 * Fix for opensource tests * Fixed signed/unsigned warning * address review notes and update docs * missed the override to ensure cameras are exported * separate out proxy-shape translator for pixar plugin into completely separate plugin This fixes some linking issues, as well as sandboxes any linking against pixar-maya-libraries (ie, usdMaya) Also adds a CMAKE flag for controlling whether to build ProxyShapeTranslator or not - BUILD_USDMAYA_PXR_TRANSLATORS * misc changes for usd-0.18.09 compatibility * get rid of warning about unused errorString (for PXR_STRICT_BUILD_MODE) did this by actually checking the return value for get*s, and using the error string, presumably as intended * Missing pair of DLL exports * USD 18.09 update * Use default PXR_PLUGINPATH_NAME environment variable * [pxrUsdTranslators] Fixed unit tests * [schemas] Fixed unit tests * added support for subsample export * ensure we don't get any funny sub-sample behaviour * 0.29.1 updates * fix for animated Transforms Were a few problems with animated Transform nodes: - TransformationMatrix::setPrim would reset time to the default value - computing the value of xform attrs would not check / update the time - not all xform attrs were marked as "affected by" all the time attrs Also made sure that a single compute won't trigger multiple calls to updateTransform (previously, this could happen if, say, both time and timeOffset were dirty; this was probably pretty infrequent, but with new changes, outTime also calls updateTransform, so it would happen more often without this check) * workaround for maya-2018 bug with rotateAxis * avoid creating do-nothing xform ops * Updated docker build script for pxrUsdTranslators * TransformationMatrix: various "XformBy" methods were not needed ie, "translateBy" is redundant, because it calls the base implementation, which in turn calls "translateTo" with the updated value. In addition to being cleaner, this update may provide a small performance boost, as we avoid calling pushToPrim twice every time an xformBy method is called Also added a test to confirm behavior is still the same * Updated Animation Video link * fix shearTweak (was typo setting scaleTweak instead) * Revert "use standard MVector / MPoint / MQuaternion constants for zero/one" This reverts commit 56eaf2c. Done in response to Rob's comment here: AnimalLogic#112 (review) * fix check for non-zero scalePivotTranslate when enableReadAnimatedValues is changed * use hard-coded constants for comparison, per Rob's note * selection implementation for VP2 in maya2019 * Updated USD version in build doc * changed order of wireframe selection rendering to ensure we can see selected objects when in wireframe mode * ensure single value rotations are respected, and correctly evaluate matrices if the transforms do not match mayas approach * [tests] Unique temporary tests folder * [tests] Fixed test crash * [schemas] plugInfo.json generated in binary dir. * [schemas] Removed VALIDATE_GENERATED_SCHEMAS option * Use USD_GENSCHEMA macro
seando-adsk
pushed a commit
to autodesk-forks/AL_USDMaya
that referenced
this issue
Nov 27, 2018
1. glext.h is not in the devkit anymore, switching files 2. Adding chrono for windows only 3. Adding python libraries to fix link issue 4. MAYA-xxxx Integrating UFE into AL_USDMaya plugin - Integration of the UFE libraries include cmake lookup and cmake on/off variables to enable and disable compilation with UFE - Integration of a runtime variable to switch on/off UFE selection with the plugin - Integrate UFE selection and disabling creation of proxy nodes for usd prim selections 5. Updating runtime id, separator of USD, and adding an added header in the want ufe build ompile 6. Missing header file 7. Merging 0.28.5 into dev-adsk (AnimalLogic#9) 8. Windows build fixes: (AnimalLogic#10) * Remove treat warnings as errors (/WX) * Multiline (with \) the C++ options 9. Show the UFE selection in the viewport (AnimalLogic#11) * Show the UFE selection in the viewport * When drawing the override, if the env var MAYA_WANT_UFE_SELECTION is set get the UFE selection and for the USD items draw them in wireframe with the Maya selection color. * Code review: adding code comments * Fix spelling mistake 10. Changing PATHS to HINTS in cmake file 11. Windows build fixes (AnimalLogic#13) * MAYA-93327 - Integrate USD in Maya * Install the Windows .pdb files. * Add UFE build define when cmake flag is set. * Fix relative library path for plugInfo.json files. * Build schemas/plugInfo.json in binary folder (not source). So git status is not dirtied. * Use UFE_VERSION (instead of hard-coded value) which is set above this repo when building. * When building with UFE, we must have the UFE version defined. * Code review comments - build ufe major/minor vars in the parent rather than child (FindUFE.cmake). This way they are accessible to others. 12. MAYA-93327 - Integrate USD in Maya (AnimalLogic#14) * RPATH has been deprecated in favor or RUNPATH which is same except that it is searched after LD_LIBRARY_PATH. This gives users the ability to override the shared libraries. 13. Use local UFE and versioning fix. 14. Convert FindUFE.cmake to LF line endings. 15. Improved USD selection highlighting. 16. MAYA-88299 - Versioning for UFE and API (AnimalLogic#16) * UFE lib/dll/so/dylib with major only version (no minor). 17. Merging master (0.29.1) into dev-adsk (AnimalLogic#17) 18. MAYA-94776 - Update USD plugin to latest AL branch (AnimalLogic#18) * Adding missing pdb file for new plugin file. 19. MAYA-94776 - Update 'dev-adsk' to latest 'develop' to get VP2 Selection code (AnimalLogic#19) 20. MAYA-95136 consistent behavior with legacy VP1 selection (AnimalLogic#20) 21. MAYA-94667 deselect USD objs by clicking void area (AnimalLogic#21) * MAYA-94667 deselect USD objs by clicking void area * MAYA-94667 code review suggestions * MAYA-94667 code review suggestion 22. MAYA-95136 selection under complex transform nodes (AnimalLogic#22) 23. MAYA-95391 revert regression change (AnimalLogic#23) 24. MAYA-95391 RMB click shouldn't trigger selection (AnimalLogic#24) Port the VP1 implementation in ProxyShapeUI::select(). 25. MAYA-95322 update bounding box of AL_MayaUSD proxy shape (AnimalLogic#25) * MAYA-95322 update bounding box of AL_MayaUSD proxy shape * MAYA-95322 code review feedback 26. Temporary restore alwaysDirty ProxyDrawOrride (cherry picked from commit 6060036) MAYA-95165 : Crash when duplicating USD objects The regression was introduced by the commit https://git.autodesk.com/autodesk-forks/AL_USDMaya/commit/321be29175a43aa270bb9d50387ac335c0d483d0 To avoid that problem we cherry-picked the correction from the last updates in the develop branch. 27. MAYA-95627 - Update to latest AL develop branch v0.29.4 + USD v18.11 Merge branch 'develop' into donnels/merging_in_develop_0.29.4 28. MAYA-95627 - Update to latest AL develop branch v0.29.4 + USD v18.11 * Fixing merge (of develop branch into dev-adsk) error. 29. MAYA-95627 - Update to latest AL develop branch v0.29.4 + USD v18.11 (AnimalLogic#28) * Some minor fixes related to merging discovered when trying to merge our 'dev-adsk' branch into 'develop'. 30. Comment from initial pull request to AL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the function finds the path in the list of already existing paths, the resultingPath is set to an empty string.
This
should be
at
AL_USDMaya/lib/AL_USDMaya/AL/usdmaya/nodes/ProxyShapeSelection.cpp
Line 442 in a8f80cd
The text was updated successfully, but these errors were encountered: