Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Sidebar is not working well, not responding to toggle also redirects to home #77

Closed
1 of 2 tasks
monacodelisa opened this issue Jun 25, 2024 · 1 comment · Fixed by #78
Closed
1 of 2 tasks
Assignees
Labels
🐛 bug Something isn't working

Comments

@monacodelisa
Copy link
Member

monacodelisa commented Jun 25, 2024

Type of feature

🐛 Bug

Current behavior

Single header was used with conditional rendering however upon checking today

  • the PrimeNG sidebar was not responding to menu click toggle within post-details
  • when changing the sidebarVisible to true from the component - the sidebar showed but on closing it was redirecting from post-details to home

Suggested solution

  • go back to the previous implementation of using the layout component
  • post-details to have it's own header & footer
  • sidenav component can remain as a separate partial component

Additional context

No response

I would be willing to submit a PR to fix this issue

@monacodelisa monacodelisa added the 🌟feature New feature or request label Jun 25, 2024
@monacodelisa monacodelisa self-assigned this Jun 25, 2024
Copy link

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@monacodelisa monacodelisa changed the title Feature: Sidenav in post-details necessary adjustments of the layout and routing Bug: Sidebar is not working well, not responding to toggle also redirects to home Jun 25, 2024
@monacodelisa monacodelisa added 🐛 bug Something isn't working and removed 🌟feature New feature or request labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant