Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Inconsistency in GraphQL Query for Author Data #74

Closed
1 of 2 tasks
monacodelisa opened this issue May 18, 2024 · 3 comments · Fixed by #75
Closed
1 of 2 tasks

Bug: Inconsistency in GraphQL Query for Author Data #74

monacodelisa opened this issue May 18, 2024 · 3 comments · Fixed by #75
Assignees
Labels
🐛 bug Something isn't working

Comments

@monacodelisa
Copy link
Member

monacodelisa commented May 18, 2024

Describe the bug

We need to address an inconsistency in our GraphQL query that retrieves author data from Hashnode's API.

  • In the file graphql.operations.ts on lines 139 and 175, the query should be changed, we need to get:
  • id
  • name
  • and username should be added too
  • verify that cases are for the author.

image

  • in the post.ts file, the author interface should be adjusted, the usarname property needs to be added

image

To see the changes

  • in the post-details component we need to change post.author.name to post.author.username

image

Browsers

Chrome

Additional context (Is this in dev or production?)

No response

I would be willing to submit a PR to fix this issue

@monacodelisa monacodelisa added the 🐛 bug Something isn't working label May 18, 2024
Copy link

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@MestiriBaha
Copy link
Contributor

@monacodelisa I would love to work on this issue !

@monacodelisa
Copy link
Member Author

@MestiriBaha you are now assigned :) if you have any questions - ask here or in the angular-primeng discord channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants