Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the camera visualization window flexible #1171

Open
XX-Yin opened this issue Dec 12, 2024 · 0 comments
Open

make the camera visualization window flexible #1171

XX-Yin opened this issue Dec 12, 2024 · 0 comments

Comments

@XX-Yin
Copy link
Collaborator

XX-Yin commented Dec 12, 2024

Different rigs may require different camera visualization layout, which makes sense to have a flexible way to change the layout based on camera settings.

Bruno suggested

If the cameras are hardcoded, I think the best you can do without a substantial amount of work is to have 2 layout files that are passed via the command line interface (https://bonsai-rx.org/docs/articles/cli.html#specifying-layout-files-in-application-mode) and probably ensure that the application does not try to connect with the non-existing camera (see #190 (comment)).

If a deeper code refactoring is on the table, I would probably suggest adopting a procedural generation pattern that works with any number of connected cameras. See the the Aind.Behavior.VideoEncodingBenchmarks repository for an example on how to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant