Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload manifest issues #1114

Closed
alexpiet opened this issue Dec 3, 2024 · 4 comments
Closed

Upload manifest issues #1114

alexpiet opened this issue Dec 3, 2024 · 4 comments
Assignees

Comments

@alexpiet
Copy link
Collaborator

alexpiet commented Dec 3, 2024

It appears there are multiple issues related to data upload. This appears to only being happening on the production_testing branch

  • Saved data is stored at behavior_behavior_<mouse_id>_<date time> instead of behavior_<mouse_id>_<date time>
  • The behavior modality is not accurately being added to the upload manifest
@alexpiet
Copy link
Collaborator Author

alexpiet commented Dec 3, 2024

I suspect the behavior_behavior_ issue is something to do with #1003. @micahwoodard Can you take a look?

I suspect the behavior modality not being added is due to #1051 causing a breaking change. @XX-Yin Can you take a look?

@alexpiet
Copy link
Collaborator Author

alexpiet commented Dec 3, 2024

To be explicit about the behavior modality: the upload manifest code checks for Modality.BEHAVIOR in stream.stream_modalities, yet in sessions generated by the testing branch, there is no Modality.BEHAVIOR in stream.stream_modalities.

@XX-Yin Is this intentional? If so, we need to modify the upload manifest code. If not, we need to fix how we make the session.json

@XX-Yin
Copy link
Collaborator

XX-Yin commented Dec 3, 2024

It's intentional to remove the behavior from the stream per Saskia's suggestion. This is one error I found.

@XX-Yin
Copy link
Collaborator

XX-Yin commented Dec 3, 2024

@alexpiet I will make PR to update the manifest code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants