Add Waterlog Mouse class with common operations #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mochic
reviewed
Sep 23, 2024
| restriction: SlimsWaterRestrictionEvent | ||
| all_restrictions: list[SlimsWaterRestrictionEvent] | ||
|
|
||
| def __init__(self, barcode: str, user: SlimsUser, slims_client=None): |
There was a problem hiding this comment.
Maybe user can be a union of string username or SlimsUser?
| self._fetch_data() | ||
| self._fetch_pks() | ||
|
|
||
| def _fetch_data(self): |
There was a problem hiding this comment.
Maybe we can implement these as properties and lazily fetch them. I can anticipate this class being used to get more than just water-related information; behavior sessions, surgical procedures, etc. Maybe it's not good to do all these fetches on instance init.
| ): | ||
| """Creates and adds a new waterlog weight/water record to SLIMS, and | ||
| updates self.waterlog_results accordingly""" | ||
| if total_water is None: |
There was a problem hiding this comment.
Is total water ever going to not be water_supplement_delivered + water_earned?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collects common operations into a class that can be used instead of juggling different records. Probably a useful pattern in other cases as well.