Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate metrics into aind-motion-correction capsule #36

Open
arielleleon opened this issue Oct 14, 2024 · 5 comments
Open

Integrate metrics into aind-motion-correction capsule #36

arielleleon opened this issue Oct 14, 2024 · 5 comments
Assignees

Comments

@arielleleon
Copy link
Collaborator

No description provided.

@arielleleon
Copy link
Collaborator Author

arielleleon commented Oct 14, 2024

Sean will create a new branch on aind-ophys-motion-correction to integrate metrics. He will test in the CodeOcean Test environment by creating a pipeline with only this capsule

blocked by #37

@arielleleon
Copy link
Collaborator Author

#37 Is now ready

@arielleleon
Copy link
Collaborator Author

@seanmcculloch will work on this today

@arielleleon
Copy link
Collaborator Author

@seanmcculloch To have this done by the end of the week.

@seanmcculloch
Copy link
Collaborator

seanmcculloch commented Nov 5, 2024

Using branch 40-create-qc-json

Testing from capsule: https://codeocean.allenneuraldynamics.org/capsule/9347369/tree

Current Status:

  • Modeling the QC.json for motion_correction after module: FOV Quality and Motion Correction (example)
  • quality_control.py creates the quality_control.json
  • Plots used:
    • <plane_id>_registration_summary.png
    • combines max and average projections into <plane_id>_combined_projections.png

Next Steps:

  1. Need to run on existing data, and manually upload the created quality_control.json to docDB
    a. Example capsule here for pushing to docDB: see
    "Alternate Workflow" at the end of run_capsule.py (As-is this capsule writes to the dev docDB)
    b. Or, write quality_control.json to the data asset in S3, then wait for sync to docDB (every 4hrs)
    Note: Ensure filepath plots are accurate to their final locations in the data asset. The 'reference' field of each QC metric should be a relative path from the root of the data asset.(This would be done at the later metadata aggregtion step but is needed now to be able to view in the QC portal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants