Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double try/except #16

Open
jeromelecoq opened this issue Oct 25, 2023 · 3 comments
Open

Remove double try/except #16

jeromelecoq opened this issue Oct 25, 2023 · 3 comments

Comments

@jeromelecoq
Copy link
Collaborator

Can this be simplified?

def get_frame_rate_platform_json(input_dir: str) -> float:

There are 2 layers of try except

@jeromelecoq
Copy link
Collaborator Author

Correction 3 layers as the function is also called in a try except.
I don't think we need a separate function. This is called only once.

@jeromelecoq
Copy link
Collaborator Author

In my view, if the frame rate can't be found, we should let this module crash.

@arielleleon
Copy link
Collaborator

Frame rate is now grabbed from the session json. @jeromelecoq, this is in a draft PR on motion correction. Can you confirm that you are OK with this solution.
#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants