Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically run and check-in black and isort linters #11

Open
7 tasks
jtyoung84 opened this issue Feb 8, 2023 · 2 comments
Open
7 tasks

Automatically run and check-in black and isort linters #11

jtyoung84 opened this issue Feb 8, 2023 · 2 comments
Assignees

Comments

@jtyoung84
Copy link
Collaborator

User story

As a developer, I want a github action to run and commit linters, so I don't have to worry about running it locally before pushing commits.

Acceptance criteria

  • When a PR is opened, there should be a step to automatically run black . and isort . and commit the changes to the current branch.

Sprint Ready Checklist

  • 1. Acceptance criteria defined
  • 2. Team understands acceptance criteria
  • 3. Team has defined solution / steps to satisfy acceptance criteria
  • 4. Acceptance criteria is verifiable / testable
  • 5. External / 3rd Party dependencies identified
  • 6. Ticket is prioritized and sized

Notes

Add any helpful notes here.

@galenlynch
Copy link
Collaborator

galenlynch commented Jul 19, 2024

Sorry @jtyoung84 I just noticed that you might have planned to work on this? The scripts dir has something that looks like your work.

@galenlynch galenlynch reopened this Jul 19, 2024
@jtyoung84
Copy link
Collaborator Author

That script was from a request you had to be able to run the linters and tests in one command.

I can assign someone to do this ticket that will auto push the linter changes to main when a PR is merged. The basic workflow will look like:

  • Someone opens a PR
  • A GitHub action runs the linters and checks format
  • If the PR is merged, then any changes made by the linters will be committed to the main branch

@jtyoung84 jtyoung84 self-assigned this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants