Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 246 ip materials #294

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Feat 246 ip materials #294

wants to merge 2 commits into from

Conversation

mekhlakapoor
Copy link
Contributor

@mekhlakapoor mekhlakapoor commented Nov 13, 2024

closes #246

  • Parses out the nonviral material info for an IP Injection from string field "doseSub".
  • Parser will be able to parse most solutions that follow general pattern of "{solution} (concentration}".
  • If an input is longer than 30 characters, it maps to None.
  • If it doesn't match the pattern, it'll return the string in the name of the nonviral material.
  • If it doesn't have the concentration or concentration unit, it will return the string in the name.
  • Tested against subset of the 41 unique values

check with @saskiad once back:

  • the aind-data-schema Nonviralmaterial has a default value for concentration unit. Is it safe to assume that unit for "2% evans blue" etc? Otherwise, we can override the default with None
  • Is there an assumed RRID?

Copy link
Contributor

@saskiad saskiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good

@saskiad
Copy link
Contributor

saskiad commented Dec 5, 2024

the aind-data-schema Nonviralmaterial has a default value for concentration unit. Is it safe to assume that unit for "2% evans blue" etc? Otherwise, we can override the default with None

No. percentage has be either mass/mass or volume/volume, and the default is mass/volume.
If it's is possible to map "%" to "percent" or "%" that would be ideal.

Is there an assumed RRID?

no. These are unique to substances - and not all substances have them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse materials for IP injections
2 participants