Consider nesting Calibration
in Device
#855
bruno-f-cruz
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Is your feature request related to a problem? Please describe.
In all the cases I have encountered,
Calibration
is always tied to a specific device. Indeed, the current spec makes this clear in theCalibration
class by adding adevice_name
REQUIRED property to keep track of this associationaind-data-schema/src/aind_data_schema/models/devices.py
Lines 270 to 278 in 0328cbe
Describe the solution you'd like
Make calibration a nested field inside
Device
with theOptional[Calibration]
typing. For hardware instantiation and experiment specification, this would be a huge help and it would allow users to not have to grab cross-referenced data across different classes (well actually across schemas, since Calibration is currently also stored in Session (?))Describe alternatives you've considered
N/A
Beta Was this translation helpful? Give feedback.
All reactions