Avoid setting out of range DAScale values #2184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-b
force-pushed
the
feature/2184-avoid-setting-out-of-scale-stim-scale-factor
branch
from
fdd77a9
to
4db0a55
Compare
t-b
force-pushed
the
feature/2184-avoid-setting-out-of-scale-stim-scale-factor
branch
from
4db0a55
to
8833ec8
Compare
t-b
force-pushed
the
feature/2184-avoid-setting-out-of-scale-stim-scale-factor
branch
2 times, most recently
from
17eb7cf
to
9526a6e
Compare
t-b
force-pushed
the
feature/2184-avoid-setting-out-of-scale-stim-scale-factor
branch
2 times, most recently
from
9fdf459
to
c273d9e
Compare
t-b
force-pushed
the
feature/2184-avoid-setting-out-of-scale-stim-scale-factor
branch
from
c273d9e
to
d405cc7
Compare
t-b
force-pushed
the
feature/2184-avoid-setting-out-of-scale-stim-scale-factor
branch
6 times, most recently
from
1c6935c
to
dd12972
Compare
t-b
force-pushed
the
feature/2184-avoid-setting-out-of-scale-stim-scale-factor
branch
2 times, most recently
from
4de9fa6
to
0690cc7
Compare
t-b
force-pushed
the
feature/2184-avoid-setting-out-of-scale-stim-scale-factor
branch
2 times, most recently
from
21d3431
to
7e3214b
Compare
We don't return voltages for all hardware types, so the current name is confusing. So let's rename it.
Missed in 85d6c5b (ReachTargetVoltage: Convert to V3 analysis function, 2020-11-20).
We want to only act specially on the very first sweep. But as we reset the index, we will land in this branch on every sweep if the resistance is too small. Let's prefer comparing to the number of acquired sweeps instead.
We need to calculate the extrema after filling them into the final stimset to accomodate for trailing baseline which is zero.
When limitCheck is true we now return 1 when setting the new DAScale value would be out of range for the current external command sensitivity of the MCC amplifier. This also requires that we now pass in the sweep number. The default of limitCheck is still false. Only when all analysis functions are ported, can we flip the default.
We can't check the limits in the PRE_DAQ_EVENT event, so we have to disable it there. And we also need to respect the index starting at -1 to stop early on the last sweep of the stimset.
t-b
force-pushed
the
feature/2184-avoid-setting-out-of-scale-stim-scale-factor
branch
from
7e3214b
to
5ea6e84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSQ_Rampnot neededPSQ_Rampnot neededReachTargetVoltagenot neededPSQ_Rampnot neededReachTargetVoltagenot neededPSQ_Rampnot neededRequires:
Close #2120