-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Sutter amplifier support #2126
Open
MichaelHuth
wants to merge
2
commits into
main
Choose a base branch
from
feature/2126-sutter-amplifier-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@t-b Here is a table with the settable IPA options: CCMode // Sets headstage to Current Clamp
VCMode // Sets headstage to Voltage Clamp
IHold // Sets the holding current in Current clamp to value
VHold // Sets the holding potential in Voltage clamp to value
Filter // Sets the amplifier filter setting (same for CC and VC).
Possible settings are (500;1kHz;2kHz;5kHz;10kHz;20kHz).
Function will set to the closest setting given an actual value.
Thus, either 5000 or 4900 will set the filter to 5kHz
IFilter // see above
VFilter // see above
VGain // Sets the input gain in Current clamp mode. Possible settings are 10;20;50;100;200;500 mV/mV).
IGain // Sets the input gain in Current clamp mode. Possible settings are (0.5;1;2.5;5;10;25 mV/pA).
// remark: Shouldn't that be a different clamp mode here?
Offset // Sets the offset (in Volts)
OffsetLock // Toggles the offset lock
ECompMag // Sets electrode compensation magnitude (SI units, so value is between 0 and 25e-12).
ECompTau // Sets electrode compensation tau value (SI units, between 0.1e-6 and 4.5e-6).
RsComp // Sets the whole-cell compensation Rs value (between 0 and 100e6).
CmComp // Sets the whole-cell compensation Cm value (between 0 and 100e-12).
RsPred // Sets the series resistance prediction value (% between 0 and 1).
RsCorr // Sets the series resistance correction value (% between 0 and 1).
RsLag // Sets the series resistance correction lag time (between 0 and 200e-6).
Bridge // Sets current clamp bridge balance (between 0 to 200e6).
BridgeOn // Enables/disables bridge balance.
AutoEComp // Activates the automatic electrode compensation routine
AutoCellComp // Activates the automatic cell compensation routine.
RsCompOn // Rs Compensation enabled
RsCorrOn //Prediction/Correction enabled
DynHold // Sets the dynamic hold voltage (between -1 and 1 V) for slow voltage control in CC mode.
DynHoldOn // Enables/disables dynamic hold.
ECompOn // Enables/disables electrode compensation (capacitance neutralization) in current clamp mode.
VHoldOn // Enables/disables holding potential in VC mode
IHoldOn // Enables/disables holding current in CC mode.
AutoOffset // Calls the automatic offset control
SealTest // Sets the HS#1 seal test. Value=0 off; otherwise value is amplitude in mV
// (scaled 20 pA/unit in CC). SealTest automatically turns off if the amplifier is switched from VC to CC
// (or vice versa), or if the headstage tab is changed (on the dIPA or multiple amplifiers). Seal test has a
// 100ms duration which cannot be changed. Note: the seal test is not functional on headstage 2 of
// the dIPA. If you require a seal test for the dIPA, please contact Sutter Instrument for a software solution.
Buzz
|
Note to self: Figure out mapping between MCC controls and IPA names. Only support IPA ones which are on the MCC GUI window. |
MichaelHuth
force-pushed
the
feature/2126-sutter-amplifier-support
branch
from
June 7, 2024 14:51
ae2068c
to
9880788
Compare
Sutter IPA control procedures and Sutter XOP 2.60 are Copyright Sutter Instrument Corp. 2015 - 2024 The package was provided by Telly Galiatsatos [email protected]
MichaelHuth
force-pushed
the
feature/2126-sutter-amplifier-support
branch
4 times, most recently
from
June 10, 2024 10:37
d309547
to
4754f7b
Compare
- Moved MCC specific Amplifier functions to MIES_AmplifierInteraction_MolecularDevices.ipf - prefixed these functions with AIMCC_ - For all non-static AI_ functions, added abstraction that depending on device the MCC functions is called or a placeholder for Sutter amplifier is used. - Added device argument to AI_ functions that did not used one, adapted depending call sites - Kept checks of optional arguments in public AI_ functions - Changed function declaration of public AIMCC_ functions to not use optional arguments The reason is that optional arguments can not easily promoted through function calls. - Added updateView argument to AIMCC_UpdateAmpModel as ParamIsDefault state of value was used also for decision for updating the AmpView. This does not change the previous behavior. - Adapted function declaration of all AIMCC_ functions to use modern syntax
MichaelHuth
force-pushed
the
feature/2126-sutter-amplifier-support
branch
from
June 10, 2024 14:01
4754f7b
to
fefd7fd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Sutter amplifier support to MIES