ir: thread vscale range from State to Type #1139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effort to support checking of programs with scalable vectors, add syntactic support for vscale and vscale_range, making the vscale an smt::expr in State. For the moment, we fail to type-check any program using scalable vectors.
Thread the vscale range information, which is an smt::expr in State to various functions in Type, cascading down to a final numElementsConst(), in preparation for the first step in supporting scalable vectors.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (auto agg = ty.getAsAggregateType()) { | ||
| // non-pointer vectors are stored/loaded all at once | ||
| if (agg->isVectorType()) { | ||
| auto &elemTy = agg->getChild(0); | ||
| if (!elemTy.isPtrType()) | ||
| return divide_up(agg->numElementsConst() * elemTy.bits(), 8); | ||
| return divide_up( | ||
| agg->numElementsConst(vscaleRange) * elemTy.bits(vscaleRange), 8); |
Check failure
Code scanning / CodeQL
Multiplication result converted to larger type High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread the vscale range information, which is an smt::expr in State to various functions in Type, cascading down to a final numElementsConst(), in preparation for the first step in supporting scalable vectors.
-- 8< --
Based on #1121.