NeoTree showing poor contrast

[bini-x]

Hi, I started using Nordic and I think it's a fantastic colorscheme, but I've had a problem with some NeoTree colors.

As you can see in this screenshot, text color of a git renamed file has some very low contrast (and the folders in which changes have been made). Also when I add a new file or dir through NeoTree, text also has very low contrast as shown in this image:

[5-pebbles]

I don't use the plugin, but I will look into it sometime this week. If you have colors (from the palette) you think would be a good fit, let me know or create a PR.

Either way, I don't plan on adding anything more to the next release (#144) so any changes will probably take a while to end up on main.

[bini-x]

i would say name of files to be white3 (#ECEFF4), background: black0 (#191D24), name of directories: gray5 (#60728A), renamed git files: gray5 or gray4 (#4C566A), text of when adding a file (the dialog): white3. So basically: white3, black0 and gray5 (maybe gray4 if you see it reasonably). If I wasn't clear enough feel free to contact me again and thanks for considering the fix.

[AlexvZyl]

Agreed that it does not look good. You can open a PR if you want? It is pretty simple.

[bini-x]

Oh okay, sorry for misunderstanding.

…

On Tue, 24 Sept 2024, 10:42 Alexander van Zyl, ***@***.***> wrote: Agreed that it does not look good. You can open a PR if you want? It is pretty simple. — Reply to this email directly, view it on GitHub <#157 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQXXRWGUZNT4CMM3Y7QU7HLZYEQYNAVCNFSM6AAAAABOVVWY2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZQGY2DGMZQHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[AlexvZyl]

Might be some miscommunication, but you did not misunderstand anything as far as I can tell :)

Either way, do you need guidance on how to do the PR?

[bini-x]

Yeah true, just didn't get that PR means Pull Request😅. Now I'm a bit busy but later I'll try to figure it out. If I need any help I'll let you know. Thanks!

…

On Tue, 24 Sept 2024, 11:58 Alexander van Zyl, ***@***.***> wrote: Might be some miscommunication, but you did not misunderstand anything as far as I can tell :) Either way, do you need guidance on how to do the PR? — Reply to this email directly, view it on GitHub <#157 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQXXRWG3XG4RPKHNTSFEDPLZYEZUDAVCNFSM6AAAAABOVVWY2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZQHAZDEMZQG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[bini-x]

Ignore my last emails. I'm trying to create a pull request but it says that I have to be a collaborator: [image: image.png] On Thu, Sep 26, 2024 at 2:11 PM Erblin Hiseni ***@***.***> wrote:

…

Hey sorry I might be disturbing you but I think I found the way to add these to your repo. Is this the piece of code I have to change (the part of NeoTree): [image: image.png] On Thu, Sep 26, 2024 at 2:08 PM Erblin Hiseni ***@***.***> wrote: > [image: image.png] > also added Line15 as you can see, it fixed the background color of the > file name > > On Thu, Sep 26, 2024 at 1:59 PM Erblin Hiseni ***@***.***> > wrote: > >> Hi Alex! >> Just wanted to let you know that I've never made a color scheme or >> plugin for neovim, so I don't know if it's a good idea to do a PR. >> Here's how I fixed it on my config: >> [image: image.png] >> Is there any way to add this piece of code on the github repo or not? >> >> On Tue, Sep 24, 2024 at 12:14 PM Erblin Hiseni ***@***.***> >> wrote: >> >>> Yeah true, just didn't get that PR means Pull Request😅. >>> Now I'm a bit busy but later I'll try to figure it out. If I need any >>> help I'll let you know. >>> Thanks! >>> >>> On Tue, 24 Sept 2024, 11:58 Alexander van Zyl, < >>> ***@***.***> wrote: >>> >>>> Might be some miscommunication, but you did not misunderstand anything >>>> as far as I can tell :) >>>> >>>> Either way, do you need guidance on how to do the PR? >>>> >>>> — >>>> Reply to this email directly, view it on GitHub >>>> <#157 (comment)>, >>>> or unsubscribe >>>> <https://github.com/notifications/unsubscribe-auth/AQXXRWG3XG4RPKHNTSFEDPLZYEZUDAVCNFSM6AAAAABOVVWY2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZQHAZDEMZQG4> >>>> . >>>> You are receiving this because you authored the thread.Message ID: >>>> ***@***.***> >>>> >>>

[AlexvZyl]

You have to fork nordic, and then create a PR from your fork :)

[bini-x]

Thanks, I'll do that now

…

On Thu, 26 Sept 2024, 14:46 Alexander van Zyl, ***@***.***> wrote: You have to fork nordic, and then create a PR from your fork :) — Reply to this email directly, view it on GitHub <#157 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQXXRWDF3KQOXXE7HEEZJI3ZYP62DAVCNFSM6AAAAABOVVWY2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZWHA2TINZTGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[bini-x]

[image: image.png] if there's anything you don't like, feel free to let me know On Thu, Sep 26, 2024 at 2:53 PM Erblin Hiseni ***@***.***> wrote:

…

Thanks, I'll do that now On Thu, 26 Sept 2024, 14:46 Alexander van Zyl, ***@***.***> wrote: > You have to fork nordic, and then create a PR from your fork :) > > — > Reply to this email directly, view it on GitHub > <#157 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AQXXRWDF3KQOXXE7HEEZJI3ZYP62DAVCNFSM6AAAAABOVVWY2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZWHA2TINZTGM> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >