Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON API returns error for "/json/live" #4205

Open
1 task done
Cerothen opened this issue Oct 18, 2024 · 7 comments
Open
1 task done

JSON API returns error for "/json/live" #4205

Cerothen opened this issue Oct 18, 2024 · 7 comments
Labels

Comments

@Cerothen
Copy link

What happened?

When attempting to use the http://host/liveview page nothing was loading, upon closer inspection the api located at http://host/json/live was returning the following:

{"error": 4}

The "Peek" feature in the regular UI works as expected however it is communicating using websocket messages and not with the same JSON api resource

To Reproduce Bug

Navigate to http://host/liveview when using version 0.15.0-b6 "Kosen"

image

Expected Behavior

The assumption is that the http://host/json/live api resource would return a non-error

Install Method

Binary from WLED.me

What version of WLED?

WLED 0.15.0-b6 (build 2410140)

Which microcontroller/board are you seeing the problem on?

ESP8266

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Cerothen Cerothen added the bug label Oct 18, 2024
@blazoncek
Copy link
Collaborator

JSON live has been disabled by default in b6.

@Cerothen
Copy link
Author

Is the intent to have the live view page be removed or switch to use the websocket?

@blazoncek
Copy link
Collaborator

If you want to use it, custom compile. Otherwise switch to websockects as it is more efficient.

@netmindz
Copy link
Collaborator

Could we have a check during the build that catches these incompatible set of build options?

@blazoncek
Copy link
Collaborator

If the JSON live is needed (please get users to upvote this issue) then it can be enabled in release builds.
It was omitted in an attempt to reduce binary size to fit other more important features in the future.
Actual commit: 0bbd6b7

@Cerothen
Copy link
Author

I'm not directly aware of what's needed to address the websocket however the liveview page depends on the JSON/live API. I'm just wondering if the liveview page will be rewritten to use websockets or if it is going to be removed

@blazoncek
Copy link
Collaborator

Web UI (including /liveview) uses websockets.
Nothing special needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants