Only build payload paths on attack #473
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
timokoessler
commented
Dec 9, 2024
timokoessler
commented
- Find multiple occurrences in same source
+ Find multiple occurrences in same source
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Comment on lines
27
to
32
| if (path === ".origin" || path === ".referer") { | ||
| const url = tryParseURL(str); | ||
| if (!!url && url.host === `localhost:${port}`) { | ||
| ignoredPaths++; | ||
| } | ||
| } |
There was a problem hiding this comment.
this has become complex. Any way to avoid?
There was a problem hiding this comment.
Ah, the !! is no longer necessary.
| @@ -211,7 +211,7 @@ function wrapDNSLookupCallback( | |||
| if (agent.shouldBlock()) { | |||
| return callback( | |||
| new Error( | |||
| `Zen has blocked ${attackKindHumanName("ssrf")}: ${operation}(...) originating from ${found.source}${escapeHTML(found.pathToPayload)}` | |||
| `Zen has blocked ${attackKindHumanName("ssrf")}: ${operation}(...) originating from ${found.source}${escapeHTML(found.pathsToPayload.join())}` | |||
There was a problem hiding this comment.
defend vs potential crash
library/sinks/undici/wrapDispatch.ts
Outdated
| @@ -110,7 +110,7 @@ function blockRedirectToPrivateIP(url: URL, context: Context, agent: Agent) { | |||
|
|
|||
| if (agent.shouldBlock()) { | |||
| throw new Error( | |||
| `Zen has blocked ${attackKindHumanName("ssrf")}: fetch(...) originating from ${found.source}${escapeHTML(found.pathToPayload)}` | |||
| `Zen has blocked ${attackKindHumanName("ssrf")}: fetch(...) originating from ${found.source}${escapeHTML(found.pathsToPayload.join())}` | |||
There was a problem hiding this comment.
defend vs potential crash
library/helpers/attackPath.ts
Outdated
|
|
||
| const attackPayloadLowercase = attackPayload.toLowerCase(); | ||
|
|
||
| const traverse = (value: unknown, path: PathPart[] = []) => { |
There was a problem hiding this comment.
should we add a max_depth
There was a problem hiding this comment.
Because this is only executed in case of an attack, it's not so important for performance, or?
hansott
reviewed
Dec 9, 2024
Comment on lines
27
to
32
| if (path === ".origin" || path === ".referer") { | ||
| const url = tryParseURL(str); | ||
| if (!!url && url.host === `localhost:${port}`) { | ||
| ignoredPaths++; | ||
| } | ||
| } |
Co-authored-by: Hans Ott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.