Detect more auth headers and cookies #380
Open
+83
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timokoessler
approved these changes
Sep 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
| @@ -36,6 +36,7 @@ const commonAuthCookieNames = [ | |||
| "auth_token", | |||
| "access_token", | |||
| "refresh_token", | |||
| "ghost-admin-api-session", | |||
There was a problem hiding this comment.
let's just change these to contains
hansott
changed the title
timokoessler
approved these changes
Sep 20, 2024
hansott
commented
Oct 7, 2024
…ghost * 'main' of github.com:AikidoSec/firewall-node: (53 commits) Fix path unit tests Fix not protecting path functions of different os Cleanup Extract type Update library/helpers/shouldEnableFirewall.ts Improve envToBool Add AIKIDO_DISABLE and envToBool helper Fix ShellJS tests Unhook fs functions that are not dangerous Increase code coverage Add distinct test with safe context Add happy path test Use separate method for distinct Undici/Fetch: Add metadata for SSRF Check filter for NoSQL of mongodb distinct Add test (no injection) Fix NoSQL injection bypass Add comment Remove lock file, not used (Docker container) Move server ...
|
We will want to port this to Python as well. I will make a PR once this one gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.