Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing events #171

Open
1 task done
a-caruso opened this issue Jul 13, 2023 · 7 comments
Open
1 task done

Missing events #171

a-caruso opened this issue Jul 13, 2023 · 7 comments
Assignees

Comments

@a-caruso
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

What's missing?

In the List of events at page https://developer.adobe.com/commerce/php/development/components/events-and-observers/event-list/
only events whose names start with a,b,c are listed, others are missing

@github-project-automation github-project-automation bot moved this to 🆕 Ready for Grooming in Commerce - Issues Jul 13, 2023
@jeff-matthews
Copy link
Contributor

Hi @a-caruso,

As far as I know, there are lots of events and we don't have a good way to automate documenting them from code. @goivvy graciously took the time to document a subset of events for the community, but it's not comprehensive.

It might be a good idea to add a note to the top of the page clarifying that the list is not exhasutive.

@goivvy
Copy link

goivvy commented Jul 14, 2023

@jeff-matthews Initial discussion was to split it in several pages, I believe I have all of them but the manager only published the first page.

@jeff-matthews
Copy link
Contributor

@goivvy, thanks for reminding me. I also went back and looked at your original PR before we migrated from devdocs.magento.com.

magento/devdocs#9098

I'm not sure if splitting between multiple pages makes sense anymore. In fact, I think it would be a better user experience to be able to search for all events on a single page. What do you think @goivvy?

@goivvy
Copy link

goivvy commented Jul 14, 2023

@jeff-matthews Yes, I agree.

@jeff-matthews
Copy link
Contributor

@goivvy, if you have the remaining events, please feel free to create a PR and add them to the existing page.

@goivvy
Copy link

goivvy commented Jul 14, 2023

@jeff-matthews OK, I'll work on it.

@dobooth dobooth moved this from 🆕 Ready for Grooming to 🔖 Ready for Development in Commerce - Issues Jul 20, 2023
@naomirobichaud
Copy link

Found this thread when I was looking at improvements to make events information more human readable. Thank you @goivvy for your contribution, I reference the list often. Would be amazing to enhance the coverage of this list

@jeff-matthews jeff-matthews moved this from 🔖 Ready for Development to 🏗 In progress in Commerce - Issues Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

No branches or pull requests

4 participants