Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default parameter to the middleware fn #50

Open
Amgad-Atef-Mohamed opened this issue Jan 11, 2021 · 0 comments
Open

default parameter to the middleware fn #50

Amgad-Atef-Mohamed opened this issue Jan 11, 2021 · 0 comments

Comments

@Amgad-Atef-Mohamed
Copy link

Amgad-Atef-Mohamed commented Jan 11, 2021

@eiabea @marklawlor @rimiti

if (!isUndefined(actionsTmp)) {

I think this condition wrong when anyone uses the middleware without sending the permissions parameter.

const resource = numPathComponents === 0 ? url : url.split('/').slice(0, numPathComponents + 1).join('/');

also, this condition wrong when anyone uses the middleware without sending the number of Paths parameter.

Redis storage take the second parameter as a string with is the prefix but in the readme example take an object
// Using Redis store
const acl = new Aclify.Acl(new Aclify.RedisStore(RedisClient, {prefix: 'acl_'}));

so it must be:

const acl = new Aclify.Acl(new Aclify.RedisStore(RedisClient,'acl' }));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant