Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for issue #98 (Cuda/Metal/OpenCL properties) #101

Closed

Conversation

barretpj
Copy link
Contributor

I said I didn't know what I was doing with PRs, and maybe this proves it - despite my best efforts it's still showing 5 old commits in the list, although they have no effect on the diff.

@barretpj
Copy link
Contributor Author

I don't seem to have privs to link this PR to the issue, I see no cog icon in the Development sidebar :-(

@garyo
Copy link
Contributor

garyo commented Nov 15, 2022

I don't seem to have privs to link this PR to the issue, I see no cog icon in the Development sidebar :-(

You can always just mention the issue number like this: should fix #98. That will create enough of a link.

@garyo garyo linked an issue Nov 15, 2022 that may be closed by this pull request
17 tasks
@garyo
Copy link
Contributor

garyo commented Nov 15, 2022

So the last 4 commits, f41fdfe through db5a44d are the ones you want for this? I'll try applying those directly to main and see what happens.

Copy link
Contributor

@garyo garyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will submit a cleaned up version of this PR without the intermediate changes and reverts.

@garyo
Copy link
Contributor

garyo commented Nov 15, 2022

I cherry-picked the relevant commits onto main. Closing this as merged. Thanks, Phil!

@garyo garyo closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU - extention to pass buffers with different API
2 participants