Update PyImathEuler.cpp

[faizhaque]

For issue #427 Make some changes by converting the Boost.python bindings for the Imath::Euler class to pybind11. Replaced boost.python headers and other changes. Followed the example template so still error testing. Wrappings should be somewhat functional

[linux-foundation-easycla]

• ✅login: faizhaque / (2f55125)

The committers listed above are authorized under a signed CLA.

[faizhaque]

Also a bit of a disclaimer, this is my first time using pybind11 bindings and my first time experience with this repo. Would appreciate the support!

[cary-ilm]

Thank you for the contribution!

The code itself looks good, but I'd prefer leave the src/python/PyImath code untouched and put the new pybind11 code in src/pybind11. Can you add a new file src/pybind11/PyBindImath/PyBindImathEuler.cpp with your new code there?

That will place the new code in parallel with the old. Eventually, once all of the classes are covered, we'll remove the old Boost.Python code and replace/rename the new code in its place. But until then, it's helpful to have the two in parallel.

Thanks!

[cary-ilm]

@faizhaque, we'd like to accept this contribution, but would prefer to see the changes noted above, moving the code into the pybind11 subdirectory. Would you be able to address that soon? If you have any questions, we're happy to help. Thanks!

[cary-ilm]

Following up on this again, @faizhaque, would you be able to finish off the requested changes? Thanks!

[faizhaque]

Hello, Sorry for the late changes, I created a pull request to move the file into the correct location. Sorry about the delay Faizan Haque Computer Science Major @ UF Phone Number: 813-323-1272

…

On Sun, Nov 3, 2024 at 4:19 PM Cary Phillips ***@***.***> wrote: Following up on this again, @faizhaque <https://github.com/faizhaque>, would you be able to finish off the requested changes? Thanks! — Reply to this email directly, view it on GitHub <#441 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDQZKYSHCJYKHIYLHZYMV7TZ62AO7AVCNFSM6AAAAABPKZRCISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJTGU4DANBZGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>