Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for P2P tests 817 and 819 #352

Open
sunnywang-arm opened this issue Oct 14, 2024 · 0 comments
Open

Cleanup for P2P tests 817 and 819 #352

sunnywang-arm opened this issue Oct 14, 2024 · 0 comments

Comments

@sunnywang-arm
Copy link
Contributor

sunnywang-arm commented Oct 14, 2024

P2P (Peer-to-Peer) rules in BSA spec are conditional requirements and only applicable when the system supports P2P. Since there is no way for test suite to know if system supports P2P, using -p2p option with bsa-acs is required for users to run the P2P tests.

For tests 817 and 819, there is no message about using -p2p option. Also, test 817 is always executed regardless of P2P support. Therefore, I think we need to add the code block below to both tests.

  /* Check If PCIe Hierarchy supports P2P */
  if (val_pcie_p2p_support() == NOT_IMPLEMENTED) {
    val_print(ACS_PRINT_DEBUG, "\n       The test is applicable only if the system supports", 0);
    val_print(ACS_PRINT_DEBUG, "\n       P2P traffic. If the system supports P2P, pass the", 0);
    val_print(ACS_PRINT_DEBUG, "\n       command line option '-p2p' while running the binary", 0);
    val_set_status(pe_index, RESULT_SKIP(TEST_NUM, 1));
    return;
  }

Also, it looks like the second val_pcie_p2p_support() code block in tests 901, 902, 818, 819 is redundant. Please check and remove them.

@sunnywang-arm sunnywang-arm changed the title P2P tests should be moved from bsa-acs to sbsa-acs P2P tests should only be run on demand (with -p2p option) Oct 15, 2024
@sunnywang-arm sunnywang-arm changed the title P2P tests should only be run on demand (with -p2p option) Cleanup for P2P tests 817 and 819 Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant