add additional sync finish condition check to fix infinite catchup status #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atus If sync process synced very closely to the their remote, there is a possibility that no commit since the starting LSN point. If that is the case, sync/apply workers are infinitely waiting for new commit to finish even if sync worker synced all of the log record from remote. This randomly happened while running `add_table` test when `alter_subscription_resynchronize_table()` called and wait for complete sync called. To address that issue, we can evaluate sync finish condition while pulling log records.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If sync process synced very closely to the their remote,
there is a possibility that no commit since the starting LSN point.
If that is the case, apply worker is infinitely waiting for sync worker finished, but sync worker also is waiting for new commit to finish catching up state even if sync worker synced all of the log record from remote.
This randomly happened while running
add_tabletest whenalter_subscription_resynchronize_table()called and wait for complete sync.To address that issue, we can evaluate sync finish condition while pulling log records.